Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention about moving docs directory into website #2103

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Dec 8, 2019

Motivation

I've been receiving quite a number of questions regarding the Now deployment setup for Docusaurus v1 projects. It'll be helpful to mention that the docs have to be moved into website.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See Netlify.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@yangshun yangshun requested a review from wgao19 as a code owner December 8, 2019 07:49
@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 8, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 8, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit db1faa0

https://deploy-preview-2103--docusaurus-preview.netlify.com

@yangshun yangshun requested a review from endiliey December 8, 2019 07:54
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit db1faa0

https://deploy-preview-2103--docusaurus-2.netlify.com

@@ -50,6 +50,8 @@ now

**That's all.** Your docs will automatically be deployed.

> Note that the directory structure Now supports is slightly different from the default directory structure of a Docusaurus project - The `docs` directory has to be within the `website` directory, ideally following the directory structure in this example. You will also have to specify a `customDocsPath` value in `siteConfig.js`. Take a look at the the [now-examples repository for a Docusaurus project](https://github.com/zeit/now-examples/tree/master/docusaurus).
Copy link
Contributor

@wgao19 wgao19 Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow "Now" on the first line is capitalized.
Nevermind, it is referring to the product...

@wgao19
Copy link
Contributor

wgao19 commented Dec 9, 2019

i can understand this recommendation. we have moved docs inside website because it somehow didnt work outside and i did not have the work hour to figure that out.

i would like to also flag that having docs live inside our website isnt optimal for our project because our project is a monorepo, the docsite is one of the repos, but we prefer a doc directory at root

@yangshun
Copy link
Contributor Author

yangshun commented Dec 9, 2019

but we prefer a doc directory at root

Why? What are the use cases for such a structure?

@yangshun yangshun merged commit 2fcb815 into master Dec 9, 2019
@yangshun yangshun deleted the docs-v1 branch December 9, 2019 08:00
@wgao19
Copy link
Contributor

wgao19 commented Dec 10, 2019

because our docs is about the whole project not individual package, it logically makes more sense to be under root not a specific package.

also, while the doc site is a nice addition, many of our developers prefer just a link to a markdown file hosted on our git, so we actually prefer them to be outside the docsite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants